This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: mediatek: vcodec: Add debug params to control different log 
level
Author:  Yunfei Dong <[email protected]>
Date:    Tue May 30 20:29:02 2023 +0800

Add parameter mtk_vcodec_dbg to open each codec log.
Add parameter mtk_v4l2_dbg_level to open each instance log according to
the parameter value.

Signed-off-by: Yunfei Dong <[email protected]>
Reviewed-by: AngeloGioacchino Del Regno 
<[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
[hverkuil: add () around 'level' in macro]

 .../platform/mediatek/vcodec/mtk_vcodec_dbgfs.c    |  2 ++
 .../platform/mediatek/vcodec/mtk_vcodec_util.c     |  8 +++++++
 .../platform/mediatek/vcodec/mtk_vcodec_util.h     | 26 +++++++++++++++++++---
 3 files changed, 33 insertions(+), 3 deletions(-)

---

diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c 
b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c
index fb9edd379af5..b5093e4e4aa2 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c
@@ -20,6 +20,8 @@ void mtk_vcodec_dbgfs_init(struct mtk_vcodec_dev *vcodec_dev)
                        IS_ERR(vcodec_dev->dbgfs.vcodec_root));
 
        vcodec_root = vcodec_dev->dbgfs.vcodec_root;
+       debugfs_create_x32("mtk_v4l2_dbg_level", 0644, vcodec_root, 
&mtk_v4l2_dbg_level);
+       debugfs_create_x32("mtk_vcodec_dbg", 0644, vcodec_root, 
&mtk_vcodec_dbg);
 }
 EXPORT_SYMBOL_GPL(mtk_vcodec_dbgfs_init);
 
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.c 
b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.c
index ace78c4b5b9e..f214e6f67005 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.c
@@ -13,6 +13,14 @@
 #include "mtk_vcodec_drv.h"
 #include "mtk_vcodec_util.h"
 
+#if defined(CONFIG_DEBUG_FS)
+int mtk_vcodec_dbg;
+EXPORT_SYMBOL(mtk_vcodec_dbg);
+
+int mtk_v4l2_dbg_level;
+EXPORT_SYMBOL(mtk_v4l2_dbg_level);
+#endif
+
 void __iomem *mtk_vcodec_get_reg_addr(struct mtk_vcodec_ctx *data,
                                        unsigned int reg_idx)
 {
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.h 
b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.h
index 71956627a0e2..88d389b65f13 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.h
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.h
@@ -35,15 +35,35 @@ struct mtk_vcodec_dev;
        pr_err("[MTK_VCODEC][ERROR][%d]: " fmt "\n",            \
               ((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args)
 
+#if defined(CONFIG_DEBUG_FS)
+extern int mtk_v4l2_dbg_level;
+extern int mtk_vcodec_dbg;
 
-#define mtk_v4l2_debug(level, fmt, args...) pr_debug(fmt, ##args)
+#define mtk_v4l2_debug(level, fmt, args...)                            \
+       do {                                                            \
+               if (mtk_v4l2_dbg_level >= (level))                      \
+                       pr_debug("[MTK_V4L2] %s, %d: " fmt "\n",        \
+                                __func__, __LINE__, ##args);           \
+       } while (0)
 
-#define mtk_v4l2_debug_enter()  mtk_v4l2_debug(3, "+")
-#define mtk_v4l2_debug_leave()  mtk_v4l2_debug(3, "-")
+#define mtk_vcodec_debug(h, fmt, args...)                                      
              \
+       do {                                                                    
              \
+               if (mtk_vcodec_dbg)                                             
              \
+                       dev_dbg(&(((struct mtk_vcodec_ctx 
*)(h)->ctx)->dev->plat_dev->dev),   \
+                               "[MTK_VCODEC][%d]: %s, %d " fmt "\n",           
              \
+                               ((struct mtk_vcodec_ctx *)(h)->ctx)->id,        
              \
+                               __func__, __LINE__, ##args);                    
              \
+       } while (0)
+#else
+#define mtk_v4l2_debug(level, fmt, args...) pr_debug(fmt, ##args)
 
 #define mtk_vcodec_debug(h, fmt, args...)                      \
        pr_debug("[MTK_VCODEC][%d]: " fmt "\n",                 \
                ((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args)
+#endif
+
+#define mtk_v4l2_debug_enter()  mtk_v4l2_debug(3, "+")
+#define mtk_v4l2_debug_leave()  mtk_v4l2_debug(3, "-")
 
 #define mtk_vcodec_debug_enter(h)  mtk_vcodec_debug(h, "+")
 #define mtk_vcodec_debug_leave(h)  mtk_vcodec_debug(h, "-")

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to