This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: ov5640: Enable MIPI interface in ov5640_set_power_mipi()
Author:  Marek Vasut <[email protected]>
Date:    Wed Aug 2 16:47:25 2023 +0200

Set OV5640_REG_IO_MIPI_CTRL00 bit 2 to 1 instead of 0, since 1 means
MIPI CSI2 interface, while 0 means CPI parallel interface.

In the ov5640_set_power_mipi() the interface should obviously be set
to MIPI CSI2 since this functions is used to power up the sensor when
operated in MIPI CSI2 mode. The sensor should not be in CPI mode in
that case.

This fixes a corner case where capturing the first frame on i.MX8MN
with CSI/ISI resulted in corrupted frame.

Fixes: aa4bb8b8838f ("media: ov5640: Re-work MIPI startup sequence")
Reviewed-by: Jacopo Mondi <[email protected]>
Tested-by: Jacopo Mondi <[email protected]> # [Test on imx6q]
Signed-off-by: Marek Vasut <[email protected]>
Tested-by: Jai Luthra <[email protected]> # [Test on bplay, sk-am62]
Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/i2c/ov5640.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 2260dbb27d86..434d8c99e23d 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -2542,9 +2542,9 @@ static int ov5640_set_power_mipi(struct ov5640_dev 
*sensor, bool on)
         *                "ov5640_set_stream_mipi()")
         * [4] = 0      : Power up MIPI HS Tx
         * [3] = 0      : Power up MIPI LS Rx
-        * [2] = 0      : MIPI interface disabled
+        * [2] = 1      : MIPI interface enabled
         */
-       ret = ov5640_write_reg(sensor, OV5640_REG_IO_MIPI_CTRL00, 0x40);
+       ret = ov5640_write_reg(sensor, OV5640_REG_IO_MIPI_CTRL00, 0x44);
        if (ret)
                return ret;
 

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to