This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: atomisp: atomisp_v4l2: Removed unnecessary code
Author:  Kate Hsuan <h...@redhat.com>
Date:    Wed Aug 2 11:56:06 2023 +0200

Here is the last step of #ifdef ISP2401 removal work. Since the driver
became generic, this part of the code was no longer needed and can
be removed.

Link: https://lore.kernel.org/r/20230802095606.1298152-13-...@redhat.com

Signed-off-by: Kate Hsuan <h...@redhat.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mche...@kernel.org>

 drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 19 -------------------
 1 file changed, 19 deletions(-)

---

diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c 
b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index 0d0329f5e4ad..c1c8501ec61f 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -1206,25 +1206,6 @@ static bool is_valid_device(struct pci_dev *pdev, const 
struct pci_device_id *id
                return false;
        }
 
-       /*
-        * FIXME:
-        * remove the if once the driver become generic
-        */
-
-#ifndef ISP2401
-       if (IS_ISP2401) {
-               dev_err(&pdev->dev, "Support for %s (ISP2401) was disabled at 
compile time\n",
-                       name);
-               return false;
-       }
-#else
-       if (!IS_ISP2401) {
-               dev_err(&pdev->dev, "Support for %s (ISP2400) was disabled at 
compile time\n",
-                       name);
-               return false;
-       }
-#endif
-
        dev_info(&pdev->dev, "Detected %s version %d (ISP240%c) on %s\n",
                 name, pdev->revision, IS_ISP2401 ? '1' : '0', product);
 

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to