This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: i2c: imx219: Remove unneeded goto
Author:  Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Date:    Sun Sep 24 18:33:04 2023 +0300

Simplify the imx219_set_stream() by removing an unneeded goto statement,
and its corresponding error label. The natural flow of the function is
correct.

While at it, drop a useless comment.

Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.steven...@raspberrypi.com>
Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 drivers/media/i2c/imx219.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

---

diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index dfc5ce574227..a12ebf288dd2 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -760,19 +760,11 @@ static int imx219_set_stream(struct v4l2_subdev *sd, int 
enable)
 
        state = v4l2_subdev_lock_and_get_active_state(sd);
 
-       if (enable) {
-               /*
-                * Apply default & customized values
-                * and then start streaming.
-                */
+       if (enable)
                ret = imx219_start_streaming(imx219, state);
-               if (ret)
-                       goto unlock;
-       } else {
+       else
                imx219_stop_streaming(imx219);
-       }
 
-unlock:
        v4l2_subdev_unlock_state(state);
        return ret;
 }

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to