This is an automatic generated email to let you know that the following patch
were queued:
Subject: media: staging: starfive: camss: fix off by one in isp_enum_mbus_code()
Author: Dan Carpenter <dan.carpen...@linaro.org>
Date: Tue Nov 28 17:40:14 2023 +0300
These > comparisons should be >=. The formats->fmts[] array is either
a pointer to isp_formats_sink[] or isp_formats_source[] respectively.
Fixes: e57854628f58 ("media: staging: media: starfive: camss: Add ISP driver")
Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
Reviewed-by: Changhuang Liang <changhuang.li...@starfivetech.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>
drivers/staging/media/starfive/camss/stf-isp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/drivers/staging/media/starfive/camss/stf-isp.c
b/drivers/staging/media/starfive/camss/stf-isp.c
index 6bffffb2b20c..d50616ef351e 100644
--- a/drivers/staging/media/starfive/camss/stf-isp.c
+++ b/drivers/staging/media/starfive/camss/stf-isp.c
@@ -120,7 +120,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
const struct stf_isp_format_table *formats;
if (code->pad == STF_ISP_PAD_SINK) {
- if (code->index > ARRAY_SIZE(isp_formats_sink))
+ if (code->index >= ARRAY_SIZE(isp_formats_sink))
return -EINVAL;
formats = &isp_dev->formats[SINK_FORMATS_INDEX];
@@ -128,7 +128,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
} else {
struct v4l2_mbus_framefmt *sink_fmt;
- if (code->index > ARRAY_SIZE(isp_formats_source))
+ if (code->index >= ARRAY_SIZE(isp_formats_source))
return -EINVAL;
sink_fmt = v4l2_subdev_state_get_format(state,
_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
