This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:

Subject: libv4l2rds: fix TMC location parsing
Author:  Hans Verkuil <hverkuil-ci...@xs4all.nl>
Date:    Wed Nov 29 13:55:20 2023 +0100

The lsb of the location was taken from block 3 instead of
block 4. Clearly a typo.

Reported-by: Thomas Shaddack <shadd...@mauriceward.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>
(cherry picked from commit db9478a91120dccc18d1388fe9b812567e33b6bb)
Signed-off-by: Gregor Jasny <gja...@googlemail.com>

 lib/libv4l2rds/libv4l2rds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

---

http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=7aad0e778c951d7893f9c4fb6934c9cdfadf00c3
diff --git a/lib/libv4l2rds/libv4l2rds.c b/lib/libv4l2rds/libv4l2rds.c
index 4bc017218c1b..dcc4ee7f7dec 100644
--- a/lib/libv4l2rds/libv4l2rds.c
+++ b/lib/libv4l2rds/libv4l2rds.c
@@ -452,7 +452,7 @@ static uint32_t rds_decode_tmc_single_group(struct 
rds_private_state *priv_state
        /* bits 0-10 of block 3 contain the event */
        msg.event = ((grp->data_c_msb & 0x07) << 8) | grp->data_c_lsb;
        /* bits 0-15 of block 4 contain the location */
-       msg.location = (grp->data_d_msb << 8) | grp->data_c_lsb;
+       msg.location = (grp->data_d_msb << 8) | grp->data_d_lsb;
        /* there is no service ID in a single group TMC message, so
         * just set it to 0. */
        msg.sid = 0;
@@ -496,7 +496,7 @@ static uint32_t rds_decode_tmc_multi_group(struct 
rds_private_state *priv_state)
                /* bits 0-10 of block 3 contain the event */
                msg->event = ((grp->data_c_msb & 0x07) << 8) | grp->data_c_lsb;
                /* bits 0-15 of block 4 contain the location */
-               msg->location = (grp->data_d_msb << 8) | grp->data_c_lsb;
+               msg->location = (grp->data_d_msb << 8) | grp->data_d_lsb;
        }
        /* second group of multigroup ? */
        /* bit 14 of block 3 ist the second group indicator, and the

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to