This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: rkisp1: Drop IRQF_SHARED
Author:  Tomi Valkeinen <[email protected]>
Date:    Thu Dec 7 08:57:45 2023 +0100

In all known platforms the ISP has dedicated IRQ lines, but for some
reason the driver uses IRQF_SHARED.

Supporting IRQF_SHARED properly requires handling interrupts even when
our device is disabled, and the driver does not handle this. To avoid
adding such code, and to be sure the driver won't accidentally be used
in a platform with shared interrupts, let's drop the IRQF_SHARED flag.

Link: 
https://lore.kernel.org/r/[email protected]

Tested-by: Adam Ford <[email protected]>  #imx8mp-beacon
Signed-off-by: Tomi Valkeinen <[email protected]>
Signed-off-by: Laurent Pinchart <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---

diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c 
b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
index 894d5afaff4e..b676db9bff62 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
@@ -542,7 +542,7 @@ static int rkisp1_probe(struct platform_device *pdev)
                if (irq < 0)
                        return irq;
 
-               ret = devm_request_irq(dev, irq, info->isrs[i].isr, IRQF_SHARED,
+               ret = devm_request_irq(dev, irq, info->isrs[i].isr, 0,
                                       dev_driver_string(dev), dev);
                if (ret) {
                        dev_err(dev, "request irq failed: %d\n", ret);

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to