[git:media_stage/master] media: usb: s2255: Refactor s2255_get_fx2fw

[Hans Verkuil]

This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: usb: s2255: Refactor s2255_get_fx2fw
Author:  Ricardo Ribalda <riba...@chromium.org>
Date:    Sun Jan 28 16:13:57 2024 +0000

Resize the buffer to the actual size needed and initialize it. With this
we can convince gcc-11 that the variable is not used uninitialized.

drivers/media/usb/s2255/s2255drv.c:1914:25: warning: 'transBuffer' may be used 
uninitialized [-Wmaybe-uninitialized]

Signed-off-by: Ricardo Ribalda <riba...@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 drivers/media/usb/s2255/s2255drv.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

---

diff --git a/drivers/media/usb/s2255/s2255drv.c 
b/drivers/media/usb/s2255/s2255drv.c
index 3c2627712fe9..8e1de1e8bd12 100644
--- a/drivers/media/usb/s2255/s2255drv.c
+++ b/drivers/media/usb/s2255/s2255drv.c
@@ -1906,9 +1906,10 @@ static int s2255_get_fx2fw(struct s2255_dev *dev)
 {
        int fw;
        int ret;
-       unsigned char transBuffer[64];
-       ret = s2255_vendor_req(dev, S2255_VR_FW, 0, 0, transBuffer, 2,
-                              S2255_VR_IN);
+       u8 transBuffer[2] = {};
+
+       ret = s2255_vendor_req(dev, S2255_VR_FW, 0, 0, transBuffer,
+                              sizeof(transBuffer), S2255_VR_IN);
        if (ret < 0)
                dprintk(dev, 2, "get fw error: %x\n", ret);
        fw = transBuffer[0] + (transBuffer[1] << 8);