This is an automatic generated email to let you know that the following patch
were queued:
Subject: media: c8sectpfe: Refactor load_c8sectpfe_fw
Author: Ricardo Ribalda <riba...@chromium.org>
Date: Thu Apr 11 21:17:53 2024 +0000
release_firmware() in the same function that it was requested. It is
more clear and makes smatch happy.
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1146
load_c8sectpfe_fw() warn: 'fw' from request_firmware() not released on lines:
1125,1132.
Signed-off-by: Ricardo Ribalda <riba...@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
index 0df2a1b4974b..2f58a0d0df85 100644
--- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
@@ -1096,7 +1096,6 @@ static int load_slim_core_fw(const struct firmware *fw,
struct c8sectpfei *fei)
}
}
- release_firmware(fw);
return err;
}
@@ -1120,6 +1119,7 @@ static int load_c8sectpfe_fw(struct c8sectpfei *fei)
}
err = load_slim_core_fw(fw, fei);
+ release_firmware(fw);
if (err) {
dev_err(fei->dev, "load_slim_core_fw failed err=(%d)\n", err);
return err;
