This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: v4l2-ctrls: Return handler error in creating new fwnode 
properties
Author:  Sakari Ailus <[email protected]>
Date:    Fri Apr 12 15:56:49 2024 +0300

If the control handler is in an error state, return that error immediately
in v4l2_ctrl_new_fwnode_properties(). Effectively the change here is that
the same error code (handler's error) is returned in all cases instead of
possibly returning -EINVAL.

Signed-off-by: Sakari Ailus <[email protected]>
Reviewed-by: Umang Jain <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>

 drivers/media/v4l2-core/v4l2-ctrls-core.c | 3 +++
 1 file changed, 3 insertions(+)

---

diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c 
b/drivers/media/v4l2-core/v4l2-ctrls-core.c
index 9a09a981e1d9..c59dd691f79f 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls-core.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c
@@ -2567,6 +2567,9 @@ int v4l2_ctrl_new_fwnode_properties(struct 
v4l2_ctrl_handler *hdl,
                                    const struct v4l2_ctrl_ops *ctrl_ops,
                                    const struct v4l2_fwnode_device_properties 
*p)
 {
+       if (hdl->error)
+               return hdl->error;
+
        if (p->orientation != V4L2_FWNODE_PROPERTY_UNSET) {
                u32 orientation_ctrl;
 

Reply via email to