This is an automatic generated email to let you know that the following patch were queued:
Subject: media: si2165: Remove redundant NULL check before release_firmware() call Author: Minghao Chi <chi.ming...@zte.com.cn> Date: Mon Jun 6 02:44:33 2022 +0100 release_firmware() checks for NULL pointers internally so checking before calling it is redundant. Link: https://lore.kernel.org/linux-media/20220606014433.290667-1-chi.ming...@zte.com.cn Reported-by: Zeal Robot <zea...@zte.com.cn> Signed-off-by: Minghao Chi <chi.ming...@zte.com.cn> Acked-by: Matthias Schwarzott <z...@gentoo.org> Signed-off-by: Mauro Carvalho Chehab <mche...@kernel.org> drivers/media/dvb-frontends/si2165.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index 434d003bf397..013d423d3263 100644 --- a/drivers/media/dvb-frontends/si2165.c +++ b/drivers/media/dvb-frontends/si2165.c @@ -513,10 +513,8 @@ static int si2165_upload_firmware(struct si2165_state *state) ret = 0; state->firmware_loaded = true; error: - if (fw) { - release_firmware(fw); - fw = NULL; - } + release_firmware(fw); + fw = NULL; return ret; }
