This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: atomisp: Disable broken V4L2_PIX_FMT_RGBX32 output support
Author:  Hans de Goede <hdego...@redhat.com>
Date:    Sat Mar 16 21:53:06 2024 +0000

Disable V4L2_PIX_FMT_RGBX32 support, because it is broken.

Selecting V4L2_PIX_FMT_RGBX32 output shows vertical columns with random
data. For each 128 pixels in a row the last 28 (32?) or so pixels contain
random data.

Signed-off-by: Hans de Goede <hdego...@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mche...@kernel.org>

 drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

---

diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c 
b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
index 9d87213a8382..756f70ac073b 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
@@ -300,12 +300,6 @@ const struct atomisp_format_bridge atomisp_output_fmts[] = 
{
                .mbus_code = MEDIA_BUS_FMT_SRGGB12_1X12,
                .sh_fmt = IA_CSS_FRAME_FORMAT_RAW,
                .description = "Bayer 12"
-       }, {
-               .pixelformat = V4L2_PIX_FMT_RGBX32,
-               .depth = 32,
-               .mbus_code = V4L2_MBUS_FMT_CUSTOM_RGB32,
-               .sh_fmt = IA_CSS_FRAME_FORMAT_RGBA888,
-               .description = "32 RGB 8-8-8-8"
        }, {
                .pixelformat = V4L2_PIX_FMT_RGB565,
                .depth = 16,
@@ -313,6 +307,17 @@ const struct atomisp_format_bridge atomisp_output_fmts[] = 
{
                .sh_fmt = IA_CSS_FRAME_FORMAT_RGB565,
                .description = "16 RGB 5-6-5"
 #if 0
+       }, {
+               /*
+                * Broken, showing vertical columns with random data.
+                * For each 128 pixels in a row the last 28 (32?) or so pixels
+                * contain random data.
+                */
+               .pixelformat = V4L2_PIX_FMT_RGBX32,
+               .depth = 32,
+               .mbus_code = V4L2_MBUS_FMT_CUSTOM_RGB32,
+               .sh_fmt = IA_CSS_FRAME_FORMAT_RGBA888,
+               .description = "32 RGB 8-8-8-8"
        }, {
                .pixelformat = V4L2_PIX_FMT_JPEG,
                .depth = 8,

Reply via email to