This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: bcm2835-unicam: Fix a NULL vs IS_ERR() check
Author:  Dan Carpenter <dan.carpen...@linaro.org>
Date:    Wed May 8 15:31:00 2024 +0300

The media_pad_remote_pad_unique() function returns error pointers, not
NULL.  Update the check accordingly.

Fixes: 392cd78d495f ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera 
interface")
Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Link: 
https://lore.kernel.org/r/fbbe7862-2820-44eb-81cb-7f33b99cca35@moroto.mountain
Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

 drivers/media/platform/broadcom/bcm2835-unicam.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c 
b/drivers/media/platform/broadcom/bcm2835-unicam.c
index bdcb04d63338..a1d93c14553d 100644
--- a/drivers/media/platform/broadcom/bcm2835-unicam.c
+++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
@@ -2433,9 +2433,9 @@ static int unicam_async_bound(struct v4l2_async_notifier 
*notifier,
                return ret;
 
        source = media_pad_remote_pad_unique(sink);
-       if (!source) {
+       if (IS_ERR(source)) {
                dev_err(unicam->dev, "No connected sensor pad\n");
-               return -ENOTCONN;
+               return PTR_ERR(source);
        }
 
        unicam->sensor.subdev = subdev;

Reply via email to