[git:media_stage/master] media: async: Warn on attept to create an ancillary link to a non-subdev

[Hans Verkuil]

This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: async: Warn on attept to create an ancillary link to a 
non-subdev
Author:  Sakari Ailus <sakari.ai...@linux.intel.com>
Date:    Mon May 20 10:28:20 2024 +0300

Warn if a lens or a flash async sub-device is bound to a non-sub-device
notifier. This isn't meaningful and unlikely to happen in practice but
print a warning as we nevertheless won't consider this an error.

Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 drivers/media/v4l2-core/v4l2-async.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

---

diff --git a/drivers/media/v4l2-core/v4l2-async.c 
b/drivers/media/v4l2-core/v4l2-async.c
index c477723c07bf..81a9b5473969 100644
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -323,8 +323,12 @@ static int v4l2_async_create_ancillary_links(struct 
v4l2_async_notifier *n,
            sd->entity.function != MEDIA_ENT_F_FLASH)
                return 0;
 
-       if (!n->sd)
+       if (!n->sd) {
+               dev_warn(notifier_dev(n),
+                        "not a sub-device notifier, not creating an ancillary 
link for %s!\n",
+                        dev_name(sd->dev));
                return 0;
+       }
 
        link = media_create_ancillary_link(&n->sd->entity, &sd->entity);