This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: subdev: Support non-routing subdevs in 
v4l2_subdev_s_stream_helper()
Author:  Tomi Valkeinen <tomi.valkei...@ideasonboard.com>
Date:    Wed Apr 24 18:39:13 2024 +0300

At the moment v4l2_subdev_s_stream_helper() only works for subdevices
that support routing. As enable/disable_streams now also works for
subdevices without routing, improve v4l2_subdev_s_stream_helper() to do
the same.

Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Tested-by: Umang Jain <umang.j...@ideasonboard.com>
Signed-off-by: Tomi Valkeinen <tomi.valkei...@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 drivers/media/v4l2-core/v4l2-subdev.c | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

---

diff --git a/drivers/media/v4l2-core/v4l2-subdev.c 
b/drivers/media/v4l2-core/v4l2-subdev.c
index 2a236f7e9f2b..4f71199bf592 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -2422,15 +2422,24 @@ int v4l2_subdev_s_stream_helper(struct v4l2_subdev *sd, 
int enable)
        if (WARN_ON(pad_index == -1))
                return -EINVAL;
 
-       /*
-        * As there's a single source pad, just collect all the source streams.
-        */
-       state = v4l2_subdev_lock_and_get_active_state(sd);
+       if (sd->flags & V4L2_SUBDEV_FL_STREAMS) {
+               /*
+                * As there's a single source pad, just collect all the source
+                * streams.
+                */
+               state = v4l2_subdev_lock_and_get_active_state(sd);
 
-       for_each_active_route(&state->routing, route)
-               source_mask |= BIT_ULL(route->source_stream);
+               for_each_active_route(&state->routing, route)
+                       source_mask |= BIT_ULL(route->source_stream);
 
-       v4l2_subdev_unlock_state(state);
+               v4l2_subdev_unlock_state(state);
+       } else {
+               /*
+                * For non-streams subdevices, there's a single implicit stream
+                * per pad.
+                */
+               source_mask = BIT_ULL(0);
+       }
 
        if (enable)
                return v4l2_subdev_enable_streams(sd, pad_index, source_mask);

Reply via email to