[git:media_stage/master] media: i2c: imx258: Issue reset before starting streaming

[Hans Verkuil]

This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: i2c: imx258: Issue reset before starting streaming
Author:  Dave Stevenson <dave.steven...@raspberrypi.com>
Date:    Wed May 1 09:24:31 2024 -0600

Whilst not documented, register 0x0103 bit 0 is the soft
reset for the sensor, so send it before trying to configure
the sensor.

Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.com>
Signed-off-by: Luis Garcia <g...@luigi311.com>
Reviewed-by: Pavel Machek <pa...@ucw.cz>
Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 drivers/media/i2c/imx258.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

---

diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index c1a2c2406aaa..9c83ba1232fa 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -20,6 +20,8 @@
 #define IMX258_MODE_STANDBY            0x00
 #define IMX258_MODE_STREAMING          0x01
 
+#define IMX258_REG_RESET               0x0103
+
 /* Chip ID */
 #define IMX258_REG_CHIP_ID             0x0016
 #define IMX258_CHIP_ID                 0x0258
@@ -1052,6 +1054,16 @@ static int imx258_start_streaming(struct imx258 *imx258)
        const struct imx258_link_freq_config *link_freq_cfg;
        int ret, link_freq_index;
 
+       ret = imx258_write_reg(imx258, IMX258_REG_RESET, IMX258_REG_VALUE_08BIT,
+                              0x01);
+       if (ret) {
+               dev_err(&client->dev, "%s failed to reset sensor\n", __func__);
+               return ret;
+       }
+
+       /* 12ms is required from poweron to standby */
+       fsleep(12000);
+
        /* Setup PLL */
        link_freq_index = imx258->cur_mode->link_freq_index;
        link_freq_cfg = &imx258->link_freq_configs[link_freq_index];