This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: mei: csi: Warn less verbosely of a missing device fwnode
Author:  Sakari Ailus <sakari.ai...@linux.intel.com>
Date:    Mon May 27 23:13:27 2024 +0300

The check for having device fwnode was meant to be a sanity check but this
also happens if the ACPI DSDT has graph port nodes on sensor device(s) but
not on the IVSC device. Use a more meaningful warning message to tell
about this.

Fixes: 33116eb12c6b ("media: ivsc: csi: Use IPU bridge")
Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 drivers/media/pci/intel/ivsc/mei_csi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

---

diff --git a/drivers/media/pci/intel/ivsc/mei_csi.c 
b/drivers/media/pci/intel/ivsc/mei_csi.c
index 53151d016188..f04a89584334 100644
--- a/drivers/media/pci/intel/ivsc/mei_csi.c
+++ b/drivers/media/pci/intel/ivsc/mei_csi.c
@@ -680,8 +680,10 @@ static int mei_csi_probe(struct mei_cl_device *cldev,
        put_device(&ipu->dev);
        if (ret < 0)
                return ret;
-       if (WARN_ON(!dev_fwnode(dev)))
+       if (!dev_fwnode(dev)) {
+               dev_err(dev, "mei-csi probed without device fwnode!\n");
                return -ENXIO;
+       }
 
        csi = devm_kzalloc(dev, sizeof(struct mei_csi), GFP_KERNEL);
        if (!csi)

Reply via email to