This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: stm32: dcmipp: correct error handling in dcmipp_create_subdevs
Author:  Alain Volmat <alain.vol...@foss.st.com>
Date:    Mon Jun 24 10:41:22 2024 +0200

Correct error handling within the dcmipp_create_subdevs by properly
decrementing the i counter when releasing the subdeves.

Fixes: 28e0f3772296 ("media: stm32-dcmipp: STM32 DCMIPP camera interface 
driver")
Cc: sta...@vger.kernel.org
Signed-off-by: Alain Volmat <alain.vol...@foss.st.com>
Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---

diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c 
b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
index 4acc3b90d03a..4924ee36cfda 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
@@ -202,7 +202,7 @@ static int dcmipp_create_subdevs(struct dcmipp_device 
*dcmipp)
        return 0;
 
 err_init_entity:
-       while (i > 0)
+       while (i-- > 0)
                dcmipp->pipe_cfg->ents[i - 1].release(dcmipp->entity[i - 1]);
        return ret;
 }

Reply via email to