This is an automatic generated email to let you know that the following patch 
were queued:

Subject: Revert "media: stm32: dcmipp: correct error handling in 
dcmipp_create_subdevs"
Author:  Hans Verkuil <hverkuil-ci...@xs4all.nl>
Date:    Thu Jun 27 13:15:31 2024 +0200

This reverts commit 77d32b7e2a7b2e5389b67363d25371b4b8cad140.

This patch is obviously wrong (causes array accesses at index -1),
and I caught that just too late.

 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---

diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c 
b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
index 4924ee36cfda..4acc3b90d03a 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
@@ -202,7 +202,7 @@ static int dcmipp_create_subdevs(struct dcmipp_device 
*dcmipp)
        return 0;
 
 err_init_entity:
-       while (i-- > 0)
+       while (i > 0)
                dcmipp->pipe_cfg->ents[i - 1].release(dcmipp->entity[i - 1]);
        return ret;
 }

Reply via email to