This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:
Subject: qv4l2: always set m_haveFramebufferSRGB to false Author: Hans Verkuil <hverkuil-ci...@xs4all.nl> Date: Tue Jul 23 15:39:16 2024 +0200 With Qt6 glEnable(GL_FRAMEBUFFER_SRGB) results in dark colors for some reason. It is fine with Qt5. Since qvidcap also ignores this (i.e. it never enables sRGB) I decided to do the same for qv4l2, so just set this to false. At some point qv4l2 should really switch to the qvidcap openGL code since it is getting to be quite a mess. Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl> utils/qv4l2/capture-win-gl.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=69b3a7618cb5dd084f5b3c27609009ff89ddae36 diff --git a/utils/qv4l2/capture-win-gl.cpp b/utils/qv4l2/capture-win-gl.cpp index 9fe9eea6043a..5b635eb7e073 100644 --- a/utils/qv4l2/capture-win-gl.cpp +++ b/utils/qv4l2/capture-win-gl.cpp @@ -301,7 +301,11 @@ void CaptureWinGLEngine::initializeGL() // for us. GLint res = 0; glGetIntegerv(GL_FRAMEBUFFER_SRGB_CAPABLE_EXT, &res); - m_haveFramebufferSRGB = res; + // With Qt6 enabling sRGB results in dark colors for some reason. + // It is fine with Qt5. + // Since qvidcap also ignores this (i.e. it never enables sRGB) + // I decided to do the same for qv4l2, so just set this to false. + m_haveFramebufferSRGB = false; if (m_haveFramebufferSRGB) glEnable(GL_FRAMEBUFFER_SRGB); m_hasGLRed = glGetString(GL_VERSION)[0] >= '3';
