[git:media_stage/master] media: mediatek: vcodec: Fix H264 multi stateless decoder smatch warning

[Hans Verkuil]

This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: mediatek: vcodec: Fix H264 multi stateless decoder smatch 
warning
Author:  Yunfei Dong <yunfei.d...@mediatek.com>
Date:    Thu Jun 13 17:33:55 2024 +0800

Fix a smatch static checker warning on vdec_h264_req_multi_if.c.
Which leads to a kernel crash when fb is NULL.

Fixes: 397edc703a10 ("media: mediatek: vcodec: add h264 decoder driver for 
mt8186")
Signed-off-by: Yunfei Dong <yunfei.d...@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno 
<angelogioacchino.delre...@collabora.com>
Signed-off-by: Sebastian Fricke <sebastian.fri...@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 .../mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c        | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

---

diff --git 
a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c 
b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
index 2d4611e7fa0b..1ed0ccec5665 100644
--- 
a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
+++ 
b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
@@ -724,11 +724,16 @@ static int vdec_h264_slice_single_decode(void *h_vdec, 
struct mtk_vcodec_mem *bs
                return vpu_dec_reset(vpu);
 
        fb = inst->ctx->dev->vdec_pdata->get_cap_buffer(inst->ctx);
+       if (!fb) {
+               mtk_vdec_err(inst->ctx, "fb buffer is NULL");
+               return -ENOMEM;
+       }
+
        src_buf_info = container_of(bs, struct mtk_video_dec_buf, bs_buffer);
        dst_buf_info = container_of(fb, struct mtk_video_dec_buf, frame_buffer);
 
-       y_fb_dma = fb ? (u64)fb->base_y.dma_addr : 0;
-       c_fb_dma = fb ? (u64)fb->base_c.dma_addr : 0;
+       y_fb_dma = fb->base_y.dma_addr;
+       c_fb_dma = fb->base_c.dma_addr;
        mtk_vdec_debug(inst->ctx, "[h264-dec] [%d] y_dma=%llx c_dma=%llx",
                       inst->ctx->decoded_frame_cnt, y_fb_dma, c_fb_dma);