On Fri Oct 18 14:34:26 2024 +0100, Lad Prabhakar wrote:
> Mark the sink and source pad with the MEDIA_PAD_FL_MUST_CONNECT flag to
> ensure pipeline validation fails if it is not connected.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad...@bp.renesas.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> Link: 
> https://lore.kernel.org/r/20241018133446.223516-4-prabhakar.mahadev-lad...@bp.renesas.com
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c 
b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
index e725982c4705..b6a118ce9fcb 100644
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
@@ -795,13 +795,15 @@ static int rzg2l_csi2_probe(struct platform_device *pdev)
        csi2->subdev.entity.function = MEDIA_ENT_F_VID_IF_BRIDGE;
        csi2->subdev.entity.ops = &rzg2l_csi2_entity_ops;
 
-       csi2->pads[RZG2L_CSI2_SINK].flags = MEDIA_PAD_FL_SINK;
+       csi2->pads[RZG2L_CSI2_SINK].flags = MEDIA_PAD_FL_SINK |
+                                           MEDIA_PAD_FL_MUST_CONNECT;
        /*
         * TODO: RZ/G2L CSI2 supports 4 virtual channels, as virtual
         * channels should be implemented by streams API which is under
         * development lets hardcode to VC0 for now.
         */
-       csi2->pads[RZG2L_CSI2_SOURCE].flags = MEDIA_PAD_FL_SOURCE;
+       csi2->pads[RZG2L_CSI2_SOURCE].flags = MEDIA_PAD_FL_SOURCE |
+                                             MEDIA_PAD_FL_MUST_CONNECT;
        ret = media_entity_pads_init(&csi2->subdev.entity, 2, csi2->pads);
        if (ret)
                goto error_pm;

Reply via email to