On Wed Nov 13 14:42:55 2024 +0000, Colin Ian King wrote:
> The variable value is being assigned a value that is never read
> afterwards, the following if statement re-assigns it with a new
> value in both paths of the if statement. The assignment is
> redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.k...@gmail.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 -
 1 file changed, 1 deletion(-)

---

diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c 
b/drivers/media/usb/cx231xx/cx231xx-avcore.c
index 6139ef5d891d..1cfec76b72f3 100644
--- a/drivers/media/usb/cx231xx/cx231xx-avcore.c
+++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c
@@ -2704,7 +2704,6 @@ int cx231xx_set_gpio_value(struct cx231xx *dev, int 
pin_number, int pin_value)
                dev->gpio_dir = value;
                status = cx231xx_set_gpio_bit(dev, dev->gpio_dir,
                                              dev->gpio_val);
-               value = 0;
        }
 
        if (pin_value == 0)

Reply via email to