On Tue Nov 19 12:56:53 2024 +0530, Dheeraj Reddy Jonnalagadda wrote:
> This commit fixes an unused value issue detected by Coverity (CID
> 1519008). The error condition for the invalid MIPI CSI-2 is not properly
> handled as the break statement would only exit the switch block and not
> the entire loop. Fix this by breaking from the look immediately after
> the switch block when an error occurs.
>
> Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linux...@gmail.com>
> Fixes: 7d4f126fde89 ("media: rkisp1: Make the internal CSI-2 receiver
> optional")
> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mo...@ideasonboard.com>
> Link:
> https://lore.kernel.org/r/20241119072653.72260-1-dheeraj.linux...@gmail.com
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
Patch committed.
Thanks,
Mauro Carvalho Chehab
drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 3 +++
1 file changed, 3 insertions(+)
---
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
index 0100b9c3edbe..dc65a7924f8a 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
@@ -228,6 +228,9 @@ static int rkisp1_subdev_notifier_register(struct
rkisp1_device *rkisp1)
break;
}
+ if (ret)
+ break;
+
/* Parse the endpoint and validate the bus type. */
ret = v4l2_fwnode_endpoint_parse(ep, &vep);
if (ret) {
