[media.git/next] media: s5p-mfc: Fix an error handling path s5p_mfc_open()

[media-ci]

On Tue Nov 19 21:42:28 2024 +0100, Christophe JAILLET wrote:
> A mfc_debug_enter() is not balanced by a corresponding mfc_debug_leave().
> Add the missing call.
> 
> Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c 
b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
index 2fe3c9228ac5..5f80931f056d 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
@@ -774,8 +774,10 @@ static int s5p_mfc_open(struct file *file)
        int ret = 0;
 
        mfc_debug_enter();
-       if (mutex_lock_interruptible(&dev->mfc_mutex))
-               return -ERESTARTSYS;
+       if (mutex_lock_interruptible(&dev->mfc_mutex)) {
+               ret = -ERESTARTSYS;
+               goto err_enter;
+       }
        dev->num_inst++;        /* It is guarded by mfc_mutex in vfd */
        /* Allocate memory for context */
        ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
@@ -946,6 +948,7 @@ err_no_ctx:
 err_alloc:
        dev->num_inst--;
        mutex_unlock(&dev->mfc_mutex);
+err_enter:
        mfc_debug_leave();
        return ret;
 }