On Fri Aug 23 17:31:21 2024 -0400, Nícolas F. R. A. Prado wrote:
> cmdq_pkt_write_mask() boils down to a cmdq_pkt_write() when the mask is
> 0xFFFFFFFF. Call cmdq_pkt_write() directly in those cases to simplify
> the code.
> 
> Suggested-by: AngeloGioacchino Del Regno 
> <angelogioacchino.delre...@collabora.com>
> Signed-off-by: Nícolas F. R. A. Prado <nfrapr...@collabora.com>
> Reviewed-by: AngeloGioacchino Del Regno 
> <angelogioacchino.delre...@collabora.com>
> Signed-off-by: Sebastian Fricke <sebastian.fri...@collabora.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>

Patch committed.

Thanks,
Mauro Carvalho Chehab

 drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

---

diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c 
b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
index df0ab338ef41..4c6d6dd62197 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
@@ -321,8 +321,7 @@ static int mdp_path_config_subfrm(struct mdp_cmdq_cmd *cmd,
        /* Enable mux settings */
        for (index = 0; index < ctrl->num_sets; index++) {
                set = &ctrl->sets[index];
-               cmdq_pkt_write_mask(&cmd->pkt, set->subsys_id, set->reg,
-                                   set->value, 0xFFFFFFFF);
+               cmdq_pkt_write(&cmd->pkt, set->subsys_id, set->reg, set->value);
        }
        /* Config sub-frame information */
        for (index = (num_comp - 1); index >= 0; index--) {
@@ -377,8 +376,7 @@ static int mdp_path_config_subfrm(struct mdp_cmdq_cmd *cmd,
        /* Disable mux settings */
        for (index = 0; index < ctrl->num_sets; index++) {
                set = &ctrl->sets[index];
-               cmdq_pkt_write_mask(&cmd->pkt, set->subsys_id, set->reg,
-                                   0, 0xFFFFFFFF);
+               cmdq_pkt_write(&cmd->pkt, set->subsys_id, set->reg, 0);
        }
 
        return 0;

Reply via email to