[media.git/next] media: stm32: dcmipp: use v4l2_subdev_is_streaming

[media-ci]

On Thu Dec 12 10:17:28 2024 +0100, Alain Volmat wrote:
> Rely on v4l2_subdev_is_streaming in order to know if the subdev
> is streaming or not instead of relying on a local variable.
> 
> Signed-off-by: Alain Volmat <alain.vol...@foss.st.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c | 6 +-----
 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c | 5 +----
 2 files changed, 2 insertions(+), 9 deletions(-)

---

diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c 
b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c
index 5a361ad6b023..50500112eab9 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c
@@ -78,7 +78,6 @@ struct dcmipp_byteproc_device {
        struct v4l2_subdev sd;
        struct device *dev;
        void __iomem *regs;
-       bool streaming;
 };
 
 static const struct v4l2_mbus_framefmt fmt_default = {
@@ -239,11 +238,10 @@ static int dcmipp_byteproc_set_fmt(struct v4l2_subdev *sd,
                                   struct v4l2_subdev_state *sd_state,
                                   struct v4l2_subdev_format *fmt)
 {
-       struct dcmipp_byteproc_device *byteproc = v4l2_get_subdevdata(sd);
        struct v4l2_mbus_framefmt *mf;
        struct v4l2_rect *crop, *compose;
 
-       if (byteproc->streaming)
+       if (v4l2_subdev_is_streaming(sd))
                return -EBUSY;
 
        mf = v4l2_subdev_state_get_format(sd_state, fmt->pad);
@@ -495,8 +493,6 @@ static int dcmipp_byteproc_s_stream(struct v4l2_subdev *sd, 
int enable)
                }
        }
 
-       byteproc->streaming = enable;
-
        return 0;
 }
 
diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c 
b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c
index 62c5c3331cfe..05e8897ae37a 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c
@@ -129,7 +129,6 @@ struct dcmipp_par_device {
        struct v4l2_subdev sd;
        struct device *dev;
        void __iomem *regs;
-       bool streaming;
 };
 
 static const struct v4l2_mbus_framefmt fmt_default = {
@@ -230,7 +229,7 @@ static int dcmipp_par_set_fmt(struct v4l2_subdev *sd,
        struct dcmipp_par_device *par = v4l2_get_subdevdata(sd);
        struct v4l2_mbus_framefmt *mf;
 
-       if (par->streaming)
+       if (v4l2_subdev_is_streaming(sd))
                return -EBUSY;
 
        mf = v4l2_subdev_state_get_format(sd_state, fmt->pad);
@@ -370,8 +369,6 @@ static int dcmipp_par_s_stream(struct v4l2_subdev *sd, int 
enable)
                reg_clear(par, DCMIPP_PRCR, DCMIPP_PRCR_ENABLE);
        }
 
-       par->streaming = enable;
-
        return ret;
 }