On Wed Dec 18 21:39:09 2024 +0000, Ricardo Ribalda wrote: > The module param `nodrop` defines what to do with frames that contain an > error: drop them or sending them to userspace. > > The default in the rest of the media subsystem is to return buffers with > an error to userspace with V4L2_BUF_FLAG_ERROR set in v4l2_buffer.flags. > In UVC we drop buffers with errors by default. > > Change the default behaviour of uvcvideo to match the rest of the > drivers and maybe get rid of the module parameter in the future. > > Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed-off-by: Ricardo Ribalda <riba...@chromium.org> > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Reviewed-by: Hans de Goede <hdego...@redhat.com> > Link: > https://lore.kernel.org/r/20241218-uvc-deprecate-v2-2-ab814139e...@chromium.org > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
Patch committed. Thanks, Mauro Carvalho Chehab drivers/media/usb/uvc/uvc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index e8df3a48196e..93ad7435fe5f 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -32,7 +32,7 @@ unsigned int uvc_clock_param = CLOCK_MONOTONIC; unsigned int uvc_hw_timestamps_param; -unsigned int uvc_no_drop_param; +unsigned int uvc_no_drop_param = 1; static unsigned int uvc_quirks_param = -1; unsigned int uvc_dbg_param; unsigned int uvc_timeout_param = UVC_CTRL_STREAMING_TIMEOUT;
