On Mon Nov 25 19:18:17 2024 +0000, Jiasheng Jiang wrote:
> Add check for the return value of clk_enable() to gurantee the success.
> 
> Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series 
> camera interface")
> Signed-off-by: Jiasheng Jiang <jiashengjiangc...@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>

Patch committed.

Thanks,
Mauro Carvalho Chehab

 drivers/media/platform/samsung/s3c-camif/camif-core.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/platform/samsung/s3c-camif/camif-core.c 
b/drivers/media/platform/samsung/s3c-camif/camif-core.c
index de6e8f151849..221e3c447f36 100644
--- a/drivers/media/platform/samsung/s3c-camif/camif-core.c
+++ b/drivers/media/platform/samsung/s3c-camif/camif-core.c
@@ -527,10 +527,19 @@ static void s3c_camif_remove(struct platform_device *pdev)
 static int s3c_camif_runtime_resume(struct device *dev)
 {
        struct camif_dev *camif = dev_get_drvdata(dev);
+       int ret;
+
+       ret = clk_enable(camif->clock[CLK_GATE]);
+       if (ret)
+               return ret;
 
-       clk_enable(camif->clock[CLK_GATE]);
        /* null op on s3c244x */
-       clk_enable(camif->clock[CLK_CAM]);
+       ret = clk_enable(camif->clock[CLK_CAM]);
+       if (ret) {
+               clk_disable(camif->clock[CLK_GATE]);
+               return ret;
+       }
+
        return 0;
 }
 

Reply via email to