[media.git/next] media: uvcvideo: Fix double free in error path

[media-ci]

On Fri Nov 8 01:51:30 2024 +0200, Laurent Pinchart wrote:
> If the uvc_status_init() function fails to allocate the int_urb, it will
> free the dev->status pointer but doesn't reset the pointer to NULL. This
> results in the kfree() call in uvc_status_cleanup() trying to
> double-free the memory. Fix it by resetting the dev->status pointer to
> NULL after freeing it.
> 
> Fixes: a31a4055473b ("V4L/DVB:usbvideo:don't use part of buffer for USB 
> transfer #4")
> Cc: sta...@vger.kernel.org
> Link: 
> https://lore.kernel.org/r/20241107235130.31372-1-laurent.pinch...@ideasonboard.com
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Reviewed by: Ricardo Ribalda <riba...@chromium.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>

Patch committed.

Thanks,
Mauro Carvalho Chehab

 drivers/media/usb/uvc/uvc_status.c | 1 +
 1 file changed, 1 insertion(+)

---

diff --git a/drivers/media/usb/uvc/uvc_status.c 
b/drivers/media/usb/uvc/uvc_status.c
index 02c90acf6964..d269d163b579 100644
--- a/drivers/media/usb/uvc/uvc_status.c
+++ b/drivers/media/usb/uvc/uvc_status.c
@@ -269,6 +269,7 @@ int uvc_status_init(struct uvc_device *dev)
        dev->int_urb = usb_alloc_urb(0, GFP_KERNEL);
        if (!dev->int_urb) {
                kfree(dev->status);
+               dev->status = NULL;
                return -ENOMEM;
        }