On Mon Nov 25 19:18:18 2024 +0000, Jiasheng Jiang wrote:
> Add check for the return value of clk_enable() to gurantee the success.
> 
> Fixes: b5f1220d587d ("[media] v4l: Add v4l2 subdev driver for S5P/EXYNOS4 
> MIPI-CSI receivers")
> Signed-off-by: Jiasheng Jiang <jiashengjiangc...@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>

Patch committed.

Thanks,
Mauro Carvalho Chehab

 drivers/media/platform/samsung/exynos4-is/mipi-csis.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c 
b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
index 63f3eecdd7e6..452880b5350c 100644
--- a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
+++ b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
@@ -940,13 +940,19 @@ static int s5pcsis_pm_resume(struct device *dev, bool 
runtime)
                                               state->supplies);
                        goto unlock;
                }
-               clk_enable(state->clock[CSIS_CLK_GATE]);
+               ret = clk_enable(state->clock[CSIS_CLK_GATE]);
+               if (ret) {
+                       phy_power_off(state->phy);
+                       regulator_bulk_disable(CSIS_NUM_SUPPLIES,
+                                              state->supplies);
+                       goto unlock;
+               }
        }
        if (state->flags & ST_STREAMING)
                s5pcsis_start_stream(state);
 
        state->flags &= ~ST_SUSPENDED;
- unlock:
+unlock:
        mutex_unlock(&state->lock);
        return ret ? -EAGAIN : 0;
 }

Reply via email to