On Tue Dec 3 21:20:09 2024 +0000, Ricardo Ribalda wrote: > ctrl->handle will only be different than NULL for controls that have > mappings. This is because that assignment is only done inside > uvc_ctrl_set() for mapped controls. > > Cc: sta...@vger.kernel.org > Fixes: e5225c820c05 ("media: uvcvideo: Send a control event when a Control > Change interrupt arrives") > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Reviewed-by: Hans de Goede <hdego...@redhat.com> > Signed-off-by: Ricardo Ribalda <riba...@chromium.org> > Link: > https://lore.kernel.org/r/20241203-uvc-fix-async-v6-2-26c867231...@chromium.org > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
Patch committed. Thanks, Mauro Carvalho Chehab drivers/media/usb/uvc/uvc_ctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index e0806641a8d0..b05b84887e51 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1640,10 +1640,8 @@ bool uvc_ctrl_status_event_async(struct urb *urb, struct uvc_video_chain *chain, struct uvc_device *dev = chain->dev; struct uvc_ctrl_work *w = &dev->async_ctrl; - if (list_empty(&ctrl->info.mappings)) { - ctrl->handle = NULL; + if (list_empty(&ctrl->info.mappings)) return false; - } w->data = data; w->urb = urb;