On Thu Dec 12 12:37:53 2024 +0100, Stanislaw Gruszka wrote:
> When ipu6 driver is waiting for the ivsc driver to probe,
> which can fail or take long time, we can get plenty of ipu6
> messages like this:
>
> [ 15.454049] intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0
> mask 0xff
> [ 15.456600] intel-ipu6 0000:00:05.0: FW version: 20230925
> [ 15.458292] intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0
> mask 0xff
> [ 15.461186] intel-ipu6 0000:00:05.0: FW version: 20230925
> [ 15.463616] intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0
> mask 0xff
> [ 15.466490] intel-ipu6 0000:00:05.0: FW version: 20230925
>
> Print them only when debugging is enabled to do not flood dmesg.
>
> Reviewed-by: Hans de Goede <[email protected]>
> Signed-off-by: Stanislaw Gruszka <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Patch committed.
Thanks,
Mauro Carvalho Chehab
drivers/media/pci/intel/ipu6/ipu6-buttress.c | 8 ++++----
drivers/media/pci/intel/ipu6/ipu6-cpd.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/drivers/media/pci/intel/ipu6/ipu6-buttress.c
b/drivers/media/pci/intel/ipu6/ipu6-buttress.c
index 277e101da137..4bcd559d7002 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-buttress.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-buttress.c
@@ -847,10 +847,10 @@ int ipu6_buttress_init(struct ipu6_device *isp)
INIT_LIST_HEAD(&b->constraints);
isp->secure_mode = ipu6_buttress_get_secure_mode(isp);
- dev_info(&isp->pdev->dev, "IPU6 in %s mode touch 0x%x mask 0x%x\n",
- isp->secure_mode ? "secure" : "non-secure",
- readl(isp->base + BUTTRESS_REG_SECURITY_TOUCH),
- readl(isp->base + BUTTRESS_REG_CAMERA_MASK));
+ dev_dbg(&isp->pdev->dev, "IPU6 in %s mode touch 0x%x mask 0x%x\n",
+ isp->secure_mode ? "secure" : "non-secure",
+ readl(isp->base + BUTTRESS_REG_SECURITY_TOUCH),
+ readl(isp->base + BUTTRESS_REG_CAMERA_MASK));
b->wdt_cached_value = readl(isp->base + BUTTRESS_REG_WDT);
writel(BUTTRESS_IRQS, isp->base + BUTTRESS_REG_ISR_CLEAR);
diff --git a/drivers/media/pci/intel/ipu6/ipu6-cpd.c
b/drivers/media/pci/intel/ipu6/ipu6-cpd.c
index 55ffd988ae4f..9e49fefa226a 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-cpd.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-cpd.c
@@ -275,7 +275,7 @@ static int ipu6_cpd_validate_moduledata(struct ipu6_device
*isp,
return -EINVAL;
}
- dev_info(&isp->pdev->dev, "FW version: %x\n", mod_hdr->fw_pkg_date);
+ dev_dbg(&isp->pdev->dev, "FW version: %x\n", mod_hdr->fw_pkg_date);
ret = ipu6_cpd_validate_cpd(isp, moduledata + mod_hdr->hdr_len,
moduledata_size - mod_hdr->hdr_len,
moduledata_size);
