On Fri Dec 6 10:26:45 2024 +0200, Tomi Valkeinen wrote:
> Clear the CRC error counter after showing it in ub953_log_status() to
> make its behavior match the other counter values.
> 
> Reviewed-by: Jai Luthra <jai.lut...@ideasonboard.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkei...@ideasonboard.com>
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>

Patch committed.

Thanks,
Mauro Carvalho Chehab

 drivers/media/i2c/ds90ub953.c | 9 +++++++++
 1 file changed, 9 insertions(+)

---

diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
index ba7bd8809d16..c49ca42e8fa4 100644
--- a/drivers/media/i2c/ds90ub953.c
+++ b/drivers/media/i2c/ds90ub953.c
@@ -65,6 +65,9 @@
 #define UB953_REG_GPIO_INPUT_CTRL_OUT_EN(n)    BIT(4 + (n))
 #define UB953_REG_GPIO_INPUT_CTRL_INPUT_EN(n)  BIT(0 + (n))
 
+#define UB953_REG_BC_CTRL                      0x49
+#define UB953_REG_BC_CTRL_CRC_ERR_CLR          BIT(3)
+
 #define UB953_REG_REV_MASK_ID                  0x50
 #define UB953_REG_GENERAL_STATUS               0x52
 
@@ -618,6 +621,12 @@ static int ub953_log_status(struct v4l2_subdev *sd)
        ub953_read(priv, UB953_REG_CRC_ERR_CNT2, &v2);
        dev_info(dev, "CRC error count %u\n", v1 | (v2 << 8));
 
+       /* Clear CRC error counter */
+       if (v1 || v2)
+               regmap_update_bits(priv->regmap, UB953_REG_BC_CTRL,
+                                  UB953_REG_BC_CTRL_CRC_ERR_CLR,
+                                  UB953_REG_BC_CTRL_CRC_ERR_CLR);
+
        ub953_read(priv, UB953_REG_CSI_ERR_CNT, &v);
        dev_info(dev, "CSI error count %u\n", v);
 

Reply via email to