On Tue Dec 3 21:29:02 2024 +0000, Jiasheng Jiang wrote:
> Add check for the return value of clk_enable() to guarantee the success.
> 
> Fixes: 81a409bfd551 ("media: marvell-ccic: provide a clock for the sensor")
> Signed-off-by: Jiasheng Jiang <jiashengjiangc...@gmail.com>
> [Sakari Ailus: Fix spelling in commit message.]
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>

Patch committed.

Thanks,
Mauro Carvalho Chehab

 drivers/media/platform/marvell/mcam-core.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

---

diff --git a/drivers/media/platform/marvell/mcam-core.c 
b/drivers/media/platform/marvell/mcam-core.c
index 9ec01228f907..b8360d37000a 100644
--- a/drivers/media/platform/marvell/mcam-core.c
+++ b/drivers/media/platform/marvell/mcam-core.c
@@ -935,7 +935,12 @@ static int mclk_enable(struct clk_hw *hw)
        ret = pm_runtime_resume_and_get(cam->dev);
        if (ret < 0)
                return ret;
-       clk_enable(cam->clk[0]);
+       ret = clk_enable(cam->clk[0]);
+       if (ret) {
+               pm_runtime_put(cam->dev);
+               return ret;
+       }
+
        mcam_reg_write(cam, REG_CLKCTRL, (mclk_src << 29) | mclk_div);
        mcam_ctlr_power_up(cam);
 

Reply via email to