On Tue Oct 15 09:40:53 2024 +0800, Zhen Lei wrote: > When function of_find_device_by_node() fails, it returns NULL instead of > an error code. So the corresponding error check logic should be modified > to check whether the return value is NULL and set the error code to be > returned as -ENODEV. > > Fixes: 46c15a4ff1f4 ("media: nuvoton: Add driver for NPCM video capture and > encoding engine") > Cc: sta...@vger.kernel.org > Signed-off-by: Zhen Lei <thunder.leiz...@huawei.com> > Link: > https://lore.kernel.org/r/20241015014053.669-1-thunder.leiz...@huawei.com > Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
Patch committed. Thanks, Mauro Carvalho Chehab drivers/media/platform/nuvoton/npcm-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c index 4f5d75645b2b..024cd8ee1709 100644 --- a/drivers/media/platform/nuvoton/npcm-video.c +++ b/drivers/media/platform/nuvoton/npcm-video.c @@ -1665,9 +1665,9 @@ static int npcm_video_ece_init(struct npcm_video *video) dev_info(dev, "Support HEXTILE pixel format\n"); ece_pdev = of_find_device_by_node(ece_node); - if (IS_ERR(ece_pdev)) { + if (!ece_pdev) { dev_err(dev, "Failed to find ECE device\n"); - return PTR_ERR(ece_pdev); + return -ENODEV; } of_node_put(ece_node);