Dear Sakari Ailus:
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:
# Test
checkpatch:./0016-media-i2c-imx214-Rectify-probe-error-handling-relate.patch
checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
#21:
- An extra pm_runtime_set_suspended() was issued in driver's remove function
total: 0 errors, 1 warnings, 0 checks, 57 lines checked
# Test
checkpatch:./0047-media-v4l-Support-passing-media-pad-argument-to-v4l2.patch
checkpatch
ERROR: Macros with complex values should be enclosed in parentheses
#79: FILE: include/media/v4l2-common.h:546:
+#define v4l2_get_link_freq(pad, mul, div)\
+_Generic(pad,\
+ struct media_pad *: __v4l2_get_link_freq_pad,\
+ struct v4l2_ctrl_handler *: __v4l2_get_link_freq_ctrl)\
+(pad, mul, div)
CHECK: Macro argument reuse 'pad' - possible side-effects?
#79: FILE: include/media/v4l2-common.h:546:
+#define v4l2_get_link_freq(pad, mul, div)\
+_Generic(pad,\
+ struct media_pad *: __v4l2_get_link_freq_pad,\
+ struct v4l2_ctrl_handler *: __v4l2_get_link_freq_ctrl)\
+(pad, mul, div)
CHECK: spaces preferred around that '*' (ctx:WxO)
#81: FILE: include/media/v4l2-common.h:548:
+ struct media_pad *: __v4l2_get_link_freq_pad,\
^
ERROR: spaces required around that ':' (ctx:OxW)
#81: FILE: include/media/v4l2-common.h:548:
+ struct media_pad *: __v4l2_get_link_freq_pad,\
^
CHECK: spaces preferred around that '*' (ctx:WxO)
#82: FILE: include/media/v4l2-common.h:549:
+ struct v4l2_ctrl_handler *: __v4l2_get_link_freq_ctrl)\
^
ERROR: spaces required around that ':' (ctx:OxW)
#82: FILE: include/media/v4l2-common.h:549:
+ struct v4l2_ctrl_handler *: __v4l2_get_link_freq_ctrl)\
^
total: 3 errors, 0 warnings, 3 checks, 64 lines checked
# Test
checkpatch:./0063-media-i2c-imx219-Increase-minimum-LLP-to-fix-blocky-.patch
checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
#15:
[1]:
https://github.com/raspberrypi/rpicam-apps/issues/281#issuecomment-1082894118
total: 0 errors, 1 warnings, 0 checks, 37 lines checked
Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/71089641/artifacts/report.htm
.
Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.
