Dear Laurent Pinchart:
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:
# Test checkpatch:./0001-media-v4l2_ctrl-Add-V4L2_CTRL_TYPE_RECT.patch
checkpatch
WARNING: Avoid logging continuation uses where feasible
#83: FILE: drivers/media/v4l2-core/v4l2-ctrls-core.c:374:
+pr_cont("%ux%u@%dx%d",
total: 0 errors, 1 warnings, 0 checks, 98 lines checked
# Test
checkpatch:./0002-media-v4l2-ctrls-add-support-for-V4L2_CTRL_WHICH_MIN.patch
checkpatch
CHECK: Alignment should match open parenthesis
#286: FILE: drivers/media/v4l2-core/v4l2-ctrls-core.c:186:
+static void std_min_compound(const struct v4l2_ctrl *ctrl, u32 idx,
+ union v4l2_ctrl_ptr ptr)
CHECK: Alignment should match open parenthesis
#297: FILE: drivers/media/v4l2-core/v4l2-ctrls-core.c:197:
+static void std_max_compound(const struct v4l2_ctrl *ctrl, u32 idx,
union v4l2_ctrl_ptr ptr)
total: 0 errors, 0 warnings, 2 checks, 598 lines checked
# Test
checkpatch:./0008-media-uvcvideo-Support-any-size-for-mapping-get-set.patch
checkpatch
CHECK: Alignment should match open parenthesis
#282: FILE: drivers/media/usb/uvc/uvc_ctrl.c:1406:
+v4l2_ctrl->default_value = uvc_mapping_get_s32(mapping,
+UVC_GET_DEF, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF));
CHECK: Alignment should match open parenthesis
#293: FILE: drivers/media/usb/uvc/uvc_ctrl.c:1440:
+v4l2_ctrl->minimum = uvc_mapping_get_s32(mapping, UVC_GET_MIN,
+uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MIN));
CHECK: Alignment should match open parenthesis
#299: FILE: drivers/media/usb/uvc/uvc_ctrl.c:1444:
+v4l2_ctrl->maximum = uvc_mapping_get_s32(mapping, UVC_GET_MAX,
+uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX));
CHECK: Alignment should match open parenthesis
#305: FILE: drivers/media/usb/uvc/uvc_ctrl.c:1448:
+v4l2_ctrl->step = uvc_mapping_get_s32(mapping, UVC_GET_RES,
+uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES));
total: 0 errors, 0 warnings, 4 checks, 332 lines checked
# Test checkpatch:./0017-media-uvcvideo-document-UVC-v1.5-ROI.patch checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
#10:
https://chromium.googlesource.com/chromiumos/platform2/+/refs/heads/release-R121-15699.B/camera/hal/usb/
total: 0 errors, 1 warnings, 0 checks, 73 lines checked
Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/72096058/artifacts/report.htm
.
Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.
