On Sun Jan 12 14:46:47 2025 +0100, Krzysztof Kozlowski wrote:
> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
> syscon_regmap_lookup_by_phandle() combined with getting the syscon
> argument.  Except simpler code this annotates within one line that given
> phandle has arguments, so grepping for code would be easier.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/ti/omap3isp/isp.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

---

diff --git a/drivers/media/platform/ti/omap3isp/isp.c 
b/drivers/media/platform/ti/omap3isp/isp.c
index a7fd808aea1e..7d549803fb92 100644
--- a/drivers/media/platform/ti/omap3isp/isp.c
+++ b/drivers/media/platform/ti/omap3isp/isp.c
@@ -2279,18 +2279,14 @@ static int isp_probe(struct platform_device *pdev)
        if (ret)
                goto error_release_isp;
 
-       isp->syscon = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,
-                                                     "syscon");
+       isp->syscon = syscon_regmap_lookup_by_phandle_args(pdev->dev.of_node,
+                                                          "syscon", 1,
+                                                          &isp->syscon_offset);
        if (IS_ERR(isp->syscon)) {
                ret = PTR_ERR(isp->syscon);
                goto error_release_isp;
        }
 
-       ret = of_property_read_u32_index(pdev->dev.of_node,
-                                        "syscon", 1, &isp->syscon_offset);
-       if (ret)
-               goto error_release_isp;
-
        isp->autoidle = autoidle;
 
        mutex_init(&isp->isp_mutex);

Reply via email to