On Mon Jan 20 15:10:40 2025 +0200, Tomi Valkeinen wrote:
> Use v4l2_subdev_{enable|disable}_streams() instead of calling s_stream
> op directly. This allows the called subdev to drop the legacy s_stream
> op.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+rene...@ideasonboard.com>
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/renesas/rcar-csi2.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/platform/renesas/rcar-csi2.c 
b/drivers/media/platform/renesas/rcar-csi2.c
index 84e6194fed6c..ff27a8845969 100644
--- a/drivers/media/platform/renesas/rcar-csi2.c
+++ b/drivers/media/platform/renesas/rcar-csi2.c
@@ -1577,7 +1577,8 @@ static int rcsi2_start(struct rcar_csi2 *priv, struct 
v4l2_subdev_state *state)
                return ret;
        }
 
-       ret = v4l2_subdev_call(priv->remote, video, s_stream, 1);
+       ret = v4l2_subdev_enable_streams(priv->remote, priv->remote_pad,
+                                        BIT_ULL(0));
        if (ret) {
                rcsi2_enter_standby(priv);
                return ret;
@@ -1589,7 +1590,7 @@ static int rcsi2_start(struct rcar_csi2 *priv, struct 
v4l2_subdev_state *state)
 static void rcsi2_stop(struct rcar_csi2 *priv)
 {
        rcsi2_enter_standby(priv);
-       v4l2_subdev_call(priv->remote, video, s_stream, 0);
+       v4l2_subdev_disable_streams(priv->remote, priv->remote_pad, BIT_ULL(0));
 }
 
 static int rcsi2_s_stream(struct v4l2_subdev *sd, int enable)

Reply via email to