On Tue Oct 22 14:50:37 2024 +0800, Yuan Can wrote:
> The smsdvb_module_init() returns without checking the retval from
> smscore_register_hotplug().
> If the smscore_register_hotplug() failed, the module failed to install,
> leaving the smsdvb_debugfs not unregistered.
>
> Fixes: 3f6b87cff66b ("[media] siano: allow showing the complete statistics
> via debugfs")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Yuan Can <yuan...@huawei.com>
> Acked-by: Ricardo Ribalda <riba...@chromium.org>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/common/siano/smsdvb-main.c | 2 ++
1 file changed, 2 insertions(+)
---
diff --git a/drivers/media/common/siano/smsdvb-main.c
b/drivers/media/common/siano/smsdvb-main.c
index 44d8fe8b220e..9b1a650ed055 100644
--- a/drivers/media/common/siano/smsdvb-main.c
+++ b/drivers/media/common/siano/smsdvb-main.c
@@ -1243,6 +1243,8 @@ static int __init smsdvb_module_init(void)
smsdvb_debugfs_register();
rc = smscore_register_hotplug(smsdvb_hotplug);
+ if (rc)
+ smsdvb_debugfs_unregister();
pr_debug("\n");
