On Fri Mar 7 12:30:16 2025 +0300, Dan Carpenter wrote:
> The num_clks is set this way:
> 
>         hdmirx_dev->num_clks = devm_clk_bulk_get_all(dev, &hdmirx_dev->clks);
>         if (hdmirx_dev->num_clks < 1)
>                 return -ENODEV;
> 
> The devm_clk_bulk_get_all() function returns negative error codes so the
> hdmirx_dev->num_cks variable needs to be signed for the error handling to
> work.
> 
> Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input 
> driver")
> Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
> Reviewed-by: Dmitry Osipenko <dmitry.osipe...@collabora.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---

diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c 
b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
index e4cdd8b5745d..3d2913de9a86 100644
--- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
+++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
@@ -151,7 +151,7 @@ struct snps_hdmirx_dev {
        bool hpd_trigger_level_high;
        bool tmds_clk_ratio;
        bool plugged;
-       u32 num_clks;
+       int num_clks;
        u32 edid_blocks_written;
        u32 cur_fmt_fourcc;
        u32 color_depth;

Reply via email to