Dear Sakari Ailus:
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:
# Test
checkpatch:./0005-media-i2c-ds90ub9xx-Add-err-parameter-to-read-write-.patch
checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
#14:
identifier FUNC =~
"^ub9.._(rxport_|txport_|ind_)?(read|write|update_bits)(16|_ind)?$";
total: 0 errors, 1 warnings, 0 checks, 1540 lines checked
# Test
checkpatch:./0014-media-i2c-ds90ub960-Add-RX-port-iteration-support.patch
checkpatch
CHECK: Macro argument reuse 'priv' - possible side-effects?
#64: FILE: drivers/media/i2c/ds90ub960.c:684:
+#define for_each_rxport(priv, it) \
+for (struct ub960_rxport_iter it = \
+ ub960_iter_rxport(priv, (struct ub960_rxport_iter){ 0 }, \
+ 0); \
+ it.nport < (priv)->hw_data->num_rxports; \
+ it.nport++, it = ub960_iter_rxport(priv, it, 0))
CHECK: Macro argument reuse 'it' - possible side-effects?
#64: FILE: drivers/media/i2c/ds90ub960.c:684:
+#define for_each_rxport(priv, it) \
+for (struct ub960_rxport_iter it = \
+ ub960_iter_rxport(priv, (struct ub960_rxport_iter){ 0 }, \
+ 0); \
+ it.nport < (priv)->hw_data->num_rxports; \
+ it.nport++, it = ub960_iter_rxport(priv, it, 0))
CHECK: Macro argument reuse 'priv' - possible side-effects?
#71: FILE: drivers/media/i2c/ds90ub960.c:691:
+#define for_each_active_rxport(priv, it) \
+for (struct ub960_rxport_iter it = \
+ ub960_iter_rxport(priv, (struct ub960_rxport_iter){ 0 }, \
+ UB960_ITER_ACTIVE_ONLY); \
+ it.nport < (priv)->hw_data->num_rxports; \
+ it.nport++, it = ub960_iter_rxport(priv, it, \
+UB960_ITER_ACTIVE_ONLY))
CHECK: Macro argument reuse 'it' - possible side-effects?
#71: FILE: drivers/media/i2c/ds90ub960.c:691:
+#define for_each_active_rxport(priv, it) \
+for (struct ub960_rxport_iter it = \
+ ub960_iter_rxport(priv, (struct ub960_rxport_iter){ 0 }, \
+ UB960_ITER_ACTIVE_ONLY); \
+ it.nport < (priv)->hw_data->num_rxports; \
+ it.nport++, it = ub960_iter_rxport(priv, it, \
+UB960_ITER_ACTIVE_ONLY))
CHECK: Macro argument reuse 'priv' - possible side-effects?
#79: FILE: drivers/media/i2c/ds90ub960.c:699:
+#define for_each_active_rxport_fpd4(priv, it) \
+for (struct ub960_rxport_iter it = \
+ ub960_iter_rxport(priv, (struct ub960_rxport_iter){ 0 }, \
+ UB960_ITER_ACTIVE_ONLY | \
+ UB960_ITER_FPD4_ONLY); \
+ it.nport < (priv)->hw_data->num_rxports; \
+ it.nport++, it = ub960_iter_rxport(priv, it, \
+UB960_ITER_ACTIVE_ONLY | \
+UB960_ITER_FPD4_ONLY))
CHECK: Macro argument reuse 'it' - possible side-effects?
#79: FILE: drivers/media/i2c/ds90ub960.c:699:
+#define for_each_active_rxport_fpd4(priv, it) \
+for (struct ub960_rxport_iter it = \
+ ub960_iter_rxport(priv, (struct ub960_rxport_iter){ 0 }, \
+ UB960_ITER_ACTIVE_ONLY | \
+ UB960_ITER_FPD4_ONLY); \
+ it.nport < (priv)->hw_data->num_rxports; \
+ it.nport++, it = ub960_iter_rxport(priv, it, \
+UB960_ITER_ACTIVE_ONLY | \
+UB960_ITER_FPD4_ONLY))
CHECK: Alignment should match open parenthesis
#309: FILE: drivers/media/i2c/ds90ub960.c:2850:
+ub960_rxport_write(priv, nport,
UB960_RR_RAW_EMBED_DTYPE,
total: 0 errors, 0 warnings, 7 checks, 518 lines checked
# Test
checkpatch:./0018-media-i2c-ds90ub953-Move-reg-defines-to-a-header-fil.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#128:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 196 lines checked
# Test checkpatch:./0059-media-dt-bindings-Add-OmniVision-OV02E10.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 113 lines checked
# Test
checkpatch:./0061-media-dt-bindings-Convert-Analog-Devices-ad5820-to-D.patch
checkpatch
WARNING: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
WARNING: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
total: 0 errors, 2 warnings, 0 checks, 63 lines checked
# Test
checkpatch:./0077-media-i2c-imx334-Enable-runtime-PM-before-sub-device.patch
checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
#9:
earlier prevents potential access to an uninitialized or powered-down device.
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/75286677/artifacts/report.htm
.
Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.
