Dear Sakari Ailus:
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:
# Test build:allmodconfig x86_64
drivers/media/i2c/ov08x40.c: In function ‘ov08x40_init_controls’:
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
2092 | u32 max;
| ^~~
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
# Test build:ACPI x86_64
drivers/media/i2c/ov08x40.c: In function ‘ov08x40_init_controls’:
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
2092 | u32 max;
| ^~~
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
# Test build:DEBUG_FS x86_64
drivers/media/i2c/ov08x40.c: In function ‘ov08x40_init_controls’:
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
2092 | u32 max;
| ^~~
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
# Test build:OF x86_64
drivers/media/i2c/ov08x40.c: In function ‘ov08x40_init_controls’:
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
2092 | u32 max;
| ^~~
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
# Test build:PM x86_64
drivers/media/i2c/ov08x40.c: In function ‘ov08x40_init_controls’:
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
2092 | u32 max;
| ^~~
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
# Test build:PM_SLEEP x86_64
drivers/media/i2c/ov08x40.c: In function ‘ov08x40_init_controls’:
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
2092 | u32 max;
| ^~~
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
# Test static-upstream:test-smatch
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
# Test static-upstream:test-sparse
drivers/media/i2c/ov08x40.c: In function ‘ov08x40_init_controls’:
drivers/media/i2c/ov08x40.c:2092:13: warning: variable ‘max’ set but not used
[-Wunused-but-set-variable]
2092 | u32 max;
| ^~~
# Test
media-patchstyle:./0003-dt-bindings-media-convert-imx.txt-to-yaml-format.patch
media style
ERROR: 08a613860d9fcc5af16ba1bb0423faccd7e55c22: Missing 'media:' prefix in
Subject
# Test
media-patchstyle:./0028-media-i2c-ds90ub960-Fix-uninitialized-variable-in-ub.patch
media style
ERROR: Commit a05744749600007f56efb16c6de727d9d541d475 found in the stable
tree, but [email protected] not in Cc:
WARNING: 'Reviewed-by:' is the preferred signature form
#11:
Reviewed-By: Jai Luthra <[email protected]>
total: 0 errors, 1 warnings, 8 lines checked
ERROR: Fails one or more mandatory checkpatch tests
# Test
media-patchstyle:./0029-media-i2c-ds90ub960-Fix-uninitialized-variable-in-ub.patch
media style
ERROR: Commit e2a3b695bc5f343391c003ecda98701808a9c433 found in the stable
tree, but [email protected] not in Cc:
WARNING: 'Reviewed-by:' is the preferred signature form
#11:
Reviewed-By: Jai Luthra <[email protected]>
total: 0 errors, 1 warnings, 8 lines checked
ERROR: Fails one or more mandatory checkpatch tests
# Test checkpatch:./0003-dt-bindings-media-convert-imx.txt-to-yaml-format.patch
checkpatch
WARNING: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
total: 0 errors, 1 warnings, 0 checks, 190 lines checked
# Test checkpatch:./0004-media-lt6911uxe-select-V4L2_CCI_I2C-in-Kconfig.patch
checkpatch
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
#9:
ERROR: modpost: "cci_write" [drivers/media/i2c/lt6911uxe.ko] undefined!
ERROR: modpost: "cci_read" [drivers/media/i2c/lt6911uxe.ko] undefined!
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
# Test
checkpatch:./0020-media-common-Add-v4l2_find_nearest_size_conditional.patch
checkpatch
CHECK: Macro argument reuse 'array' - possible side-effects?
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
CHECK: Macro argument reuse 'width_field' - possible side-effects?
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
CHECK: Macro argument 'width_field' may be better as '(width_field)' to avoid
precedence issues
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
CHECK: Macro argument reuse 'height_field' - possible side-effects?
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
CHECK: Macro argument 'height_field' may be better as '(height_field)' to avoid
precedence issues
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
total: 0 errors, 0 warnings, 5 checks, 123 lines checked
# Test
checkpatch:./0028-media-i2c-ds90ub960-Fix-uninitialized-variable-in-ub.patch
checkpatch
WARNING: 'Reviewed-by:' is the preferred signature form
#11:
Reviewed-By: Jai Luthra <[email protected]>
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
# Test
checkpatch:./0029-media-i2c-ds90ub960-Fix-uninitialized-variable-in-ub.patch
checkpatch
WARNING: 'Reviewed-by:' is the preferred signature form
#11:
Reviewed-By: Jai Luthra <[email protected]>
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/75680872/artifacts/report.htm
.
Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.
