Dear Sakari Ailus:
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:
# Test
media-patchstyle:./0003-dt-bindings-media-convert-imx.txt-to-yaml-format.patch
media style
ERROR: 9b6ba1e50f26350bdf500fe9a9be556b7551aea8: Missing 'media:' prefix in
Subject
# Test checkpatch:./0003-dt-bindings-media-convert-imx.txt-to-yaml-format.patch
checkpatch
WARNING: DT binding docs and includes should be a separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
total: 0 errors, 1 warnings, 0 checks, 190 lines checked
# Test
checkpatch:./0019-media-common-Add-v4l2_find_nearest_size_conditional.patch
checkpatch
CHECK: Macro argument reuse 'array' - possible side-effects?
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
CHECK: Macro argument reuse 'width_field' - possible side-effects?
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
CHECK: Macro argument 'width_field' may be better as '(width_field)' to avoid
precedence issues
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
CHECK: Macro argument reuse 'height_field' - possible side-effects?
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
CHECK: Macro argument 'height_field' may be better as '(height_field)' to avoid
precedence issues
#103: FILE: include/media/v4l2-common.h:414:
+#define v4l2_find_nearest_size_conditional(array, array_size, width_field, \
+ height_field, width, height, \
+ func, context) \
({\
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
sizeof((array)->height_field) != sizeof(u32)); \
+(typeof(&(array)[0]))__v4l2_find_nearest_size_conditional( \
(array), array_size, sizeof(*(array)),\
offsetof(typeof(*(array)), width_field),\
offsetof(typeof(*(array)), height_field),\
+width, height, func, context);\
})
total: 0 errors, 0 warnings, 5 checks, 123 lines checked
Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/75753811/artifacts/report.htm
.
Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.
