On Thu Apr 24 10:05:34 2025 +0300, Tomi Valkeinen wrote:
> Remove unnecessary checks wrt. formats and interfaces in rvin_setup().
> The validity of the formats has already been checked earlier.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+rene...@ideasonboard.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se>
> Tested-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se>
> Link: 
> https://lore.kernel.org/r/20250424-rcar-fix-raw-v2-2-f6afca378...@ideasonboard.com
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 23 ----------------------
 1 file changed, 23 deletions(-)

---

diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c 
b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
index 374396bcf8b9..e0464eb49b59 100644
--- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
+++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
@@ -782,29 +782,6 @@ static int rvin_setup(struct rvin_dev *vin)
                break;
        }
 
-       /* Make sure input interface and input format is valid. */
-       if (vin->info->model == RCAR_GEN3 || vin->info->model == RCAR_GEN4) {
-               switch (vnmc & VNMC_INF_MASK) {
-               case VNMC_INF_YUV8_BT656:
-               case VNMC_INF_YUV10_BT656:
-               case VNMC_INF_YUV16:
-               case VNMC_INF_RGB666:
-                       if (vin->is_csi) {
-                               vin_err(vin, "Invalid setting in MIPI CSI2\n");
-                               return -EINVAL;
-                       }
-                       break;
-               case VNMC_INF_RAW8:
-                       if (!vin->is_csi) {
-                               vin_err(vin, "Invalid setting in Digital 
Pins\n");
-                               return -EINVAL;
-                       }
-                       break;
-               default:
-                       break;
-               }
-       }
-
        /* Enable VSYNC Field Toggle mode after one VSYNC input */
        if (vin->info->model == RCAR_GEN3 || vin->info->model == RCAR_GEN4)
                dmr2 = VNDMR2_FTEV;

Reply via email to