[media.git/next] media: uvcvideo: Send control events for partial succeeds

[media-ci]

On Mon Feb 24 10:34:54 2025 +0000, Ricardo Ribalda wrote:
> Today, when we are applying a change to entities A, B. If A succeeds and B
> fails the events for A are not sent.
> 
> This change changes the code so the events for A are send right after
> they happen.
> 
> Cc: sta...@kernel.org
> Fixes: b4012002f3a3 ("[media] uvcvideo: Add support for control events")
> Signed-off-by: Ricardo Ribalda <riba...@chromium.org>
> Message-ID: <20250224-uvc-data-backup-v2-2-de993ed98...@chromium.org>
> Signed-off-by: Hans de Goede <hdego...@redhat.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/usb/uvc/uvc_ctrl.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

---

diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
index 0c4d84eab42a..636ce1eb2a6b 100644
--- a/drivers/media/usb/uvc/uvc_ctrl.c
+++ b/drivers/media/usb/uvc/uvc_ctrl.c
@@ -1954,7 +1954,9 @@ static bool uvc_ctrl_xctrls_has_control(const struct 
v4l2_ext_control *xctrls,
 }
 
 static void uvc_ctrl_send_events(struct uvc_fh *handle,
-       const struct v4l2_ext_control *xctrls, unsigned int xctrls_count)
+                                struct uvc_entity *entity,
+                                const struct v4l2_ext_control *xctrls,
+                                unsigned int xctrls_count)
 {
        struct uvc_control_mapping *mapping;
        struct uvc_control *ctrl;
@@ -1966,6 +1968,9 @@ static void uvc_ctrl_send_events(struct uvc_fh *handle,
                s32 value;
 
                ctrl = uvc_find_control(handle->chain, xctrls[i].id, &mapping);
+               if (ctrl->entity != entity)
+                       continue;
+
                if (ctrl->info.flags & UVC_CTRL_FLAG_ASYNCHRONOUS)
                        /* Notification will be sent from an Interrupt event. */
                        continue;
@@ -2209,11 +2214,12 @@ int __uvc_ctrl_commit(struct uvc_fh *handle, int 
rollback,
                                        uvc_ctrl_find_ctrl_idx(entity, ctrls,
                                                               err_ctrl);
                        goto done;
+               } else if (ret > 0 && !rollback) {
+                       uvc_ctrl_send_events(handle, entity,
+                                            ctrls->controls, ctrls->count);
                }
        }
 
-       if (!rollback)
-               uvc_ctrl_send_events(handle, ctrls->controls, ctrls->count);
        ret = 0;
 done:
        mutex_unlock(&chain->ctrl_mutex);