On Wed May 7 18:09:11 2025 +0200, Marek Szyprowski wrote: > Use common wrappers operating directly on the struct sg_table objects to > fix incorrect use of scatterlists sync calls. dma_sync_sg_for_*() > functions have to be called with the number of elements originally passed > to dma_map_sg_*() function, not the one returned in sgt->nents. > > Fixes: d4db5eb57cab ("media: videobuf2: add begin/end cpu_access callbacks to > dma-sg") > CC: sta...@vger.kernel.org > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > Reviewed-by: Sergey Senozhatsky <senozhat...@chromium.org> > Acked-by: Tomasz Figa <tf...@chromium.org> > Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>
Patch committed. Thanks, Hans Verkuil drivers/media/common/videobuf2/videobuf2-dma-sg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/common/videobuf2/videobuf2-dma-sg.c b/drivers/media/common/videobuf2/videobuf2-dma-sg.c index c6ddf2357c58..b3bf2173c14e 100644 --- a/drivers/media/common/videobuf2/videobuf2-dma-sg.c +++ b/drivers/media/common/videobuf2/videobuf2-dma-sg.c @@ -469,7 +469,7 @@ vb2_dma_sg_dmabuf_ops_begin_cpu_access(struct dma_buf *dbuf, struct vb2_dma_sg_buf *buf = dbuf->priv; struct sg_table *sgt = buf->dma_sgt; - dma_sync_sg_for_cpu(buf->dev, sgt->sgl, sgt->nents, buf->dma_dir); + dma_sync_sgtable_for_cpu(buf->dev, sgt, buf->dma_dir); return 0; } @@ -480,7 +480,7 @@ vb2_dma_sg_dmabuf_ops_end_cpu_access(struct dma_buf *dbuf, struct vb2_dma_sg_buf *buf = dbuf->priv; struct sg_table *sgt = buf->dma_sgt; - dma_sync_sg_for_device(buf->dev, sgt->sgl, sgt->nents, buf->dma_dir); + dma_sync_sgtable_for_device(buf->dev, sgt, buf->dma_dir); return 0; }