On Fri Apr 25 14:52:37 2025 +0200, Johan Hovold wrote:
> Probe deferral should not be logged as an error:
>
> ov5675 24-0010: failed to get HW configuration: -517
>
> Drop the (mostly) redundant dev_err() from sensor probe() to suppress
> it.
>
> Note that errors during clock and regulator lookup are already correctly
> logged using dev_err_probe().
>
> Fixes: 49d9ad719e89 ("media: ov5675: add device-tree support and support
> runtime PM")
> Cc: [email protected]
> Signed-off-by: Johan Hovold <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/i2c/ov5675.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/drivers/media/i2c/ov5675.c b/drivers/media/i2c/ov5675.c
index c1081deffc2f..e7aec281e9a4 100644
--- a/drivers/media/i2c/ov5675.c
+++ b/drivers/media/i2c/ov5675.c
@@ -1295,11 +1295,8 @@ static int ov5675_probe(struct i2c_client *client)
return -ENOMEM;
ret = ov5675_get_hwcfg(ov5675, &client->dev);
- if (ret) {
- dev_err(&client->dev, "failed to get HW configuration: %d",
- ret);
+ if (ret)
return ret;
- }
v4l2_i2c_subdev_init(&ov5675->sd, client, &ov5675_subdev_ops);
