[media.git/next] media: v4l: subdev: Fix coverity issue: Logically dead code

[media-ci]

On Tue Apr 8 21:31:25 2025 +0100, Chris Green wrote:
> The conditional (type == V4L2_TUNER_RADIO) always evaluates true due to the
> earlier check for (type != V4L2_TUNER_RADIO) (line 2826)
> 
> CID: 1226742
> 
> Signed-off-by: Chris Green <chris.e.gr...@hotmail.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/v4l2-core/v4l2-ioctl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

---

diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c 
b/drivers/media/v4l2-core/v4l2-ioctl.c
index e97881f74c0d..78f217768ae7 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -2835,8 +2835,7 @@ static int v4l_enum_freq_bands(const struct 
v4l2_ioctl_ops *ops,
                p->capability = m.capability | V4L2_TUNER_CAP_FREQ_BANDS;
                p->rangelow = m.rangelow;
                p->rangehigh = m.rangehigh;
-               p->modulation = (type == V4L2_TUNER_RADIO) ?
-                       V4L2_BAND_MODULATION_FM : V4L2_BAND_MODULATION_VSB;
+               p->modulation = V4L2_BAND_MODULATION_FM;
                return 0;
        }
        return -ENOTTY;